Skip to content

[CI only] Check the performance impact of tracing isSubType #6161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

abgruszecki
Copy link
Contributor

We have essentially non-local returns inside recur. The
cost of throwing exceptions inside a heavily used operation might be
non-trivial, and I'd like to check it.

See:

We have a what are essentially non-local returns inside `recur`. The
cost of throwing exceptions inside a heavily used operation might be
non-trivial.
@abgruszecki
Copy link
Contributor Author

test performance please

@dottybot
Copy link
Member

performance test scheduled: 1 job(s) in queue, 1 running.

@dottybot
Copy link
Member

Performance test finished successfully:

Visit http://dotty-bench.epfl.ch/6161/ to see the changes.

Benchmarks is based on merging with master (55aae90)

@abgruszecki
Copy link
Contributor Author

There seems to be no significant performance improvement, but perhaps that is because no test exercises codepaths using return heavily.

As a sidenote, we could do with having confidence intervals automatically calculated for performance tests - as things are right now, I'm just eyeballing whether the slight improvement in some tests is significant or not.

Closing this datapoint for now.

/cc @smarter I did a quick and dirty test to see if isSubType is impacted by non-local returns from inside the trace. Seems that it's not.

@abgruszecki abgruszecki deleted the ci-only/check-cost-of-tracing-isSubType branch March 26, 2019 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants